igmp warning (was: Re: Linux 2.4.27-pre6)

[Geert Uytterhoeven]

And this is a new one (compared to -pre3):

| igmp.c: In function `igmpv3_newpack':
| igmp.c:279: warning: `skb' might be used uninitialized in this function

And it seems to be a real bug, not a compiler glitch:

| static struct sk_buff *igmpv3_newpack(struct net_device *dev, int size)
| {
|         struct sk_buff *skb;
                          ^^^
|         struct rtable *rt;
|         struct iphdr *pip;
|         struct igmpv3_report *pig;
|         u32     dst;
|
|         dst = IGMPV3_ALL_MCR;
|         if (ip_route_output(&rt, dst, 0, 0, dev->ifindex))
|                 return 0;
|         if (rt->rt_src == 0) {
|                 kfree_skb(skb);
                            ^^^
|                 ip_rt_put(rt);
|                 return 0;
|         }


Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/