Re: [PATCH] Stop printk printing non-printable chars

From: Linus Torvalds
Date: Fri Jun 18 2004 - 16:38:34 EST




On Fri, 18 Jun 2004 matthew-lkml@xxxxxxxxxxxxxxxxxxxxx wrote:
>
> The main problem seems to be in ACPI, but I don't see any reason for
> printk to even consider printing _any_ non-printable characters at all.
> It makes all characters out of the range 32..126 (except for newline)
> print as a '?'.

How about emitting them as \xxx, so that you see what they are. And using
a case-statement to make it easy and clear when to do exceptions (I think
we should accept \t too, no?).

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/