Re: [PATCH] Add kallsyms_lookup() result cache

From: Jesse Barnes
Date: Fri Jun 18 2004 - 18:33:20 EST


On Friday, June 18, 2004 6:03 pm, Andi Kleen wrote:
> On Fri, 18 Jun 2004 15:03:00 -0500
>
> Brent Casavant <bcasavan@xxxxxxx> wrote:
> > On 2.6 based systems, the top command utilizes /proc/[pid]/wchan to
> > determine WCHAN symbol name information. This information is provided
> > by the kernel function kallsyms_lookup(), which expands a stem-compressed
>
> That sounds more like a bug in your top to me. /proc/*/wchan itself
> does not access kallsyms, it just outputs a number.undisclosed-recipients:;

No, it outputs a string:
jbarnes@mill:~$ cat /proc/1/wchan
do_select

I haven't looked, but it's probably dependent on CONFIG_KALLSYMS.

> Doing the cache in the kernel is the wrong place. This should be fixed
> in user space.

Sure, but that would be a change in behavior. It's arguably the right thing
to do though.

Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/