Re: [PATCH 1/4]Diskdump Update

[Christoph Hellwig]

On Mon, Jun 21, 2004 at 04:59:52PM +0900, Takao Indoh wrote:
> >> int cmd, unsigned long param)
> >
> >
> >ehhh this looks evil
> 
> Do you mean I should use not ioctl but the following style?
> 
> echo "add /dev/hda1" > /proc/diskdump
> echo "delete /dev/hda1" > /proc/diskdump

the right interface would probably be a dump attribute for the scsi_device
where you can echo enable or disable (or 1/0) to.  The also nicely solves
then need to find an associated scsi_device for a given block_dev.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/