Re: [PATCH 0/2] kbuild updates

[Sam Ravnborg]

On Tue, Jun 22, 2004 at 12:50:09AM +0200, Andreas Gruenbacher wrote:
> On Tuesday 22 June 2004 00:31, Sam Ravnborg wrote:
> > But Martin has a point here.
> 
> Yes.
> 
> > Other modules uses the grep method - which will fail when the kernel
> > is build with separate output and source directories.
> 
> Is there anything fundamentally wrong with invoking the test script from 
> within the module makefile, when really necessary? This doesn't work very 
> well if you need the test results outside of the module build.
> 
> 	----- Makefile -----
> 	test_result := $(shell ...)
> 	ifneq ($(test_result),)
> 	EXTRA_CFLAGS := -DSOMETHING
> 	endif
> 	...
> 	-------- 8< --------

I like keeping the kbuild makefile clean as such - but otherwise not.
One has to secure that right CFLAGS etc is used though.

Also when make -j N is used one has to be very carefully with prerequisites - as always.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/