Re: [PATCH] ppc32: Cleanups & warning fixes of traps.c

[Benjamin Herrenschmidt]

On Tue, 2004-06-22 at 17:34, Tom Rini wrote:
> On Tue, Jun 22, 2004 at 02:07:32PM -0500, Benjamin Herrenschmidt wrote:
> 
> > Hi !
> > 
> > This patch cleans up arch/ppc/kernel/traps.c and vecemu.c to use the same
> > formatting style for all functions,
> 
> Isn't that undoing what Lindent does?  Which is at least possibly why
> it's done that way now..

I don't know if that has anything to do with lindent. I used to format
that way myself but changed my mind, and paulus seemed to do both, but I
remember a recent discussion where Linus clearly explained his
preference having the return type on the same line as the function name.

It's also more handy with grep.

Ben.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/