Re: [PATCH] HPET driver

From: Jeff Garzik
Date: Wed Jun 23 2004 - 16:52:16 EST


Robert Picco wrote:
Hi Andrew:

I eliminated the request_irq brain damage, eliminated procfs support, made the check for FMODE_WRITE in hpet_open and responded to a few other suggestions.

Thanks! I'll look over it too.


I misinterpreted your desire to change HPET from using a major device number and moving to miscdevice. I thought one objective was to avoid LANANA registration. It obviously isn't and I have done LANANA registration but need a reply. So it's possible the values for hpet in miscdevice.h and devices.txt will change.

The LANANA stuff propagates to 2.4 and to vendors who update their /dev packages. You can't just pick an arbitrary number and use it. If LANANA hasn't replied, the driver should use dynamic miscdev minor, or dynamic chrdev major, until a number is assigned.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/