Re: [PATCH][2.6] Fix module_text_address/store_stackinfo race

[Zwane Mwaikambo]

On Thu, 24 Jun 2004, Rusty Russell wrote:

> I keep fighting to keep it static 8)
>
> How's this:
>
> Name: Fix race between CONFIG_DEBUG_SLABALLOC and modules
> Status: Compiled on 2.6.7
> Version: -mm
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx> (modified)
> Signed-off-by: Zwane Mwaikambo <zwane@xxxxxxxxxxx>
>
> store_stackinfo() does an unlocked module list walk during normal runtime
> which opens up a race with the module load/unload code. This can be
> triggered by simply unloading and loading a module in a loop with
> CONFIG_DEBUG_PAGEALLOC resulting in store_stackinfo() tripping over bad
> list pointers.
>
> kernel_text_address doesn't take any locks, because during an OOPS we
> don't want to deadlock.  Rename that to __kernel_text_address, and
> make kernel_text_address take the lock.

Thanks, looks good, works here.

	Zwane

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/