Re: Oops with 2.6.7-bk

From: viro
Date: Thu Jun 24 2004 - 16:27:36 EST


On Thu, Jun 24, 2004 at 11:16:49PM +0200, Marcel Holtmann wrote:
> I got this oops on boot with the latest Bitkeeper snapshot of 2.6.7

Memory corruption in generic_readlink(), now that we use nd->depth instead
of current->link_count. Fix follows:

--- fs/namei.c Thu Jun 24 16:06:45 2004
+++ fs/namei.c-fix Thu Jun 24 16:07:24 2004
@@ -2197,7 +2197,9 @@
int generic_readlink(struct dentry *dentry, char __user *buffer, int buflen)
{
struct nameidata nd;
- int res = dentry->d_inode->i_op->follow_link(dentry, &nd);
+ int res;
+ nd.depth = 0;
+ res = dentry->d_inode->i_op->follow_link(dentry, &nd);
if (!res) {
res = vfs_readlink(dentry, buffer, buflen, nd_get_link(&nd));
if (dentry->d_inode->i_op->put_link)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/