Re: sys_gettimeofday racy or not?

[Chris Friesen]

Wichert Akkerman wrote:
> This just happened to catch my eye and it's probably perfectly
> valid, but if so please educate me on why it is. In kernel/time.c
> sys_gettimeofday() there is this code:
>
>         if (unlikely(tz != NULL)) {
>                 if (copy_to_user(tz, &sys_tz, sizeof(sys_tz)))
>                         return -EFAULT;
>         }
>
> what prevents sys_tz from being changed while this code runs?

Nothing at all.

I suspect most people don't worry about it, since its use is deprecated.  The 
man page for gettimeofday() says "The use of the timezone struct is obsolete".

Chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/