Re: [PATCH 2.6] Altix serial driver

From: Christoph Hellwig
Date: Fri Jun 25 2004 - 03:34:20 EST


On Thu, Jun 24, 2004 at 10:15:41PM -0500, Erik Jacobson wrote:
> Andrew and LKML folks -
>
> Pat is on vacation and said he wouldn't mind if I posted the latest version
> of this patch.
>
> - I fixed up Kconfig (x86 problem)
> - I changed SYSFS_ONLY to USE_DYNAMIC_MINOR

Please kill the ifdef completely. As long as LANANA hasn't responded you
should only use the dyanic nimor, and once it's accepted there's no point
in using the dynamico ne anymore. Also I'd sugges grabbing a whole dyanmic
major instead of using a miscdevice so the code both cases is more similar.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/