[PATCH] signed bug in drivers/video/console/fbcon.c con2fb_map[]

From: Olaf Hering
Date: Mon Jun 28 2004 - 14:34:41 EST



drivers/video/console/fbcon.c:310: warning: comparison is always true due to limited range of data type

char can be either signed or unsigned, depending on the target system.
patch is against 2.6.7-bk11


--- drivers/video/console/fbcon.c
+++ drivers/video/console/fbcon.c 2004/06/28 19:22:45
@@ -101,7 +101,7 @@
#endif

struct display fb_display[MAX_NR_CONSOLES];
-char con2fb_map[MAX_NR_CONSOLES];
+signed char con2fb_map[MAX_NR_CONSOLES];
static int logo_height;
static int logo_lines;
static int logo_shown = -1;
--- drivers/video/console/fbcon.h
+++ drivers/video/console/fbcon.h 2004/06/28 19:23:06
@@ -36,7 +36,7 @@
};

/* drivers/video/console/fbcon.c */
-extern char con2fb_map[MAX_NR_CONSOLES];
+extern signed char con2fb_map[MAX_NR_CONSOLES];
extern int set_con2fb_map(int unit, int newidx);

/*
--
USB is for mice, FireWire is for men!

sUse lINUX ag, nÃRNBERG
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/