Re: [PATCH 2.6] Altix serial driver

[Russell King]

On Mon, Jun 28, 2004 at 12:13:12PM -0700, Andrew Morton wrote:
> Pat Gefre <pfg@xxxxxxx> wrote:
> >
> > We think we should stick with the major/minor set we have proposed.  We
> >  don't like hacking the 8250 code, dynamic allocation doesn't work (once
> >  that works we will update our driver to use it), registering for our
> >  own major/minor may not work (if we DO get one we will update the
> >  driver to reflect it) but in the meantime we need to get something in
> >  the community that works.
> 
> "we don't like" isn't a very strong argument ;)
> 
> It does sound to me like some work is needed in the generic serial layer to
> teach it to get its sticky paws off the ttyS0 major/minor if there is no
> corresponding hardware.

It isn't that simple.  As I've already pointed out, there is no provision
to do a "maybe hardware exists, maybe it doesn't, lets claim individual
ttys based upon that decision".

It's a restriction of the way the TTY layer is setup to work with the
rest of the kernel, especially the character device layer.

We have these objects called TTY drivers.  They claim a range of TTY
devices, which are attached to a major number, starting at a minimum
minor number, and extending for a certain number of minor numbers.
This marks the complete range of minor numbers as being in use.  This
occurs when a serial driver is registered _well_ before any hardware
is touched.

Separate from that, we register TTY devices for each tty line, maybe
depending on whether hardware exists.  This occurs substantially later
than when the major/minor range is reserved.

> AFAICT nobody has scoped out exactly what has to be done for a clean
> solution there - it may not be very complex.  So could we please
> explore that a little further?

Seriously, the scale of changes required to make this work without
hacks is nontrivial.  If it were trivial, I'd have done it long ago,
since then I wouldn't need /dev/ttyAM, /dev/ttySA, /dev/ttyFB etc
on ARM.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/