Re: [PATCH] hpet related

From: Robert Picco
Date: Mon Jun 28 2004 - 16:21:39 EST


Sure. I'll make the change and resend patch.
Andrew Morton wrote:

Robert Picco <Robert.Picco@xxxxxx> wrote:


+static inline void hpet_timer_reserved(struct hpet_data *hd, int timer)
+{
+ hd->hd_state |= (1 << timer);
+ return;
+}



The identifier "hpet_timer_reserved" implies (to me) that the function
queries something. Except it doesn't.

Would "hpet_reserve_timer" be a better choice?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/





-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/