Re: [PATCH 2.6.7-mm3] cirrusfb: minor fixes

[David Eger]

On Mon, Jun 28, 2004 at 09:27:27PM +0200, Francois Romieu wrote:
> Testers welcome.
> 
> - fix unbalanced invocation of pci_enable_device();
> - leaks plugged in cirrusfb_zorro_setup();
> - move framebuffer_release() into cirrusfb_{pci/zorro}_unmap() to balance
>   cirrusfb_{pci/zorro}_setup();
> - make cirrusfb_{pci/zorro}_setup() return adequate error codes when
>   something fails;
> - cirrusfb_zorro_unmap: iounmap() now take as argument values previously
>   returned by ioremap().
> 
> Signed-off-by: Francois Romieu <romieu@xxxxxxxxxxxxx>

Your patch looks great.  

Not only does it look great, with it X and cirrusfb now play nice with
each other!  Andrew, please apply.  Feel free to add my:

Signed-off-by: David Eger <eger@xxxxxxxxxxxxx>

On another note...
pci_request_regions() replaces request_mem_region()... 
looks like virtually all of the FB drivers have suffered from bit
rot.  I guess that's what you get when people just look at code in
drivers/video/ to copy..

-dte
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/