Re: [PATCH] 2.6 PPC64: lockfix for rtas error log(third-times-a-charm?)]

[Dave Hansen]

On Thu, 2004-07-01 at 12:19, linas@xxxxxxxxxxxxxx wrote:
> +	/* Log the error in the unlikely case that there was one. */
> +	if (unlikely(logit)) {
> +		buff_copy = kmalloc (RTAS_ERROR_LOG_MAX, GFP_ATOMIC);
> +		memcpy (buff_copy, rtas_err_buf, RTAS_ERROR_LOG_MAX);
> +	}

You forgot to check the allocation for failure.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/