spurious remap_file_pages() -EINVAL

From: William Lee Irwin III
Date: Sun Jul 04 2004 - 07:05:57 EST


As ->vm_private_data is used as a cursor for swapout of VM_NONLINEAR
vmas, the check for NULL ->vm_private_data or VM_RESERVED is too
strict, and should allow VM_NONLINEAR vmas with non-NULL ->vm_private_data.

This fixes an issue on 2.6.7-mm5 where system calls to remap_file_pages()
spuriously failed while under memory pressure.


Index: mm5-2.6.7/mm/fremap.c
===================================================================
--- mm5-2.6.7.orig/mm/fremap.c 2004-07-04 04:28:50.836939584 -0700
+++ mm5-2.6.7/mm/fremap.c 2004-07-04 04:30:37.645702184 -0700
@@ -194,7 +194,8 @@
* or VM_LOCKED, but VM_LOCKED could be revoked later on).
*/
if (vma && (vma->vm_flags & VM_SHARED) &&
- (!vma->vm_private_data || (vma->vm_flags & VM_RESERVED)) &&
+ (!vma->vm_private_data ||
+ (vma->vm_flags & (VM_NONLINEAR|VM_RESERVED))) &&
vma->vm_ops && vma->vm_ops->populate &&
end > start && start >= vma->vm_start &&
end <= vma->vm_end) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/