Re: force O_LARGEFILE in sys_swapon() and sys_swapoff()

From: Hugh Dickins
Date: Sun Jul 04 2004 - 14:23:27 EST


On Sat, 3 Jul 2004, William Lee Irwin III wrote:
>
> For 32-bit, one quickly discovers that swapon() is not given an fd
> already opened with O_LARGEFILE to act upon and the forcing of
> O_LARGEFILE for 64-bit is irrelevant, as the system call's argument is
> a path. So this patch manually forces it for swapon() and swapoff().

This one looks good, thanks. I'm not so sure of your more general
patch to open, others know better on that.

I doubt huge amounts of swap work at all well when used, but you're
really concerned with commit at present: of course it was silly not
to have used O_LARGEFILE here.

Hugh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/