Re: [PATCH] Update in-kernel orinoco drivers to upstream currentCVS

[Pavel Roskin]

Hello!

[trimming the cc: a bit]

On Wed, 7 Jul 2004, Michael Clark wrote:

> Just like to chime in as a tester. I've been running the orinoco CVS
> for around 6 weeks now. Has been very stable although I needed the
> attached patch to make suspend/resume work (thinkpad with APM).
>
> I posted a bug on orinoco savannah but haven't seen any changes in CVS.

Sorry, but bug tracking systems rarely provide fast turnaround.  It's 
better that you post to orinoco-devel@xxxxxxxxxxxxxxxxxxxxx to get a reply 
fast.

The patch you submitted on Savannah reverts the patch submitted by Simon 
Huggins: http://sourceforge.net/mailarchive/message.php?msg_id=7995284

The patch you attached seems to be much better.  I've applied it.

> BTW - what is the *correct* ordering of pci_(save|restore)_state,
> pci_set_power_state?

drivers/net/pci-skeleton.c doesn't have power management code, but the 
driver it was based on, 8139too.c, has such code and uses 
pci_set_power_state() after pci_(save|restore)_state().  Other well 
maintained drivers (e.g. e100.c) use pci_set_power_state() after 
pci_save_state() and before pci_restore_state().  I think it's reasonable 
to follow this example.  Jeff?

--
Regards,
Pavel Roskin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/