Re: [PATCH 1/2] Freescale MPC52xx support for 2.6 - Base part

[Sylvain Munaut]

Kumar Gala wrote:

> > > A few comments:
> > >
> > > cputable.c: * the 8280/52xx, maybe we should just have G2_LE, (same
> > > core exists in 8272, 8249, etc.)
> >
> > IMHO, yes it may be better.
>
>
> > > mpc52xx_setup.c: * what is cpu_52xx[]?
> >
> > A table with coefficients taken from datasheet. They're used to
> > compute the core frequency according to XLB bus frequency and external
> > jumper configurations.
>
>
> Mind adding the above as a comment in the code.  :)


Ok, I'll change the G2_LE and change the name/add a small comment to 
cpu_52xx.
I'll repost a new updated set of patch monday morning with just that if 
I got no other comments.


Sylvain Munaut
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/