Re: [PATCH] was: [RFC] removal of sync in panic

From: Christian Borntraeger
Date: Sun Jul 18 2004 - 02:35:20 EST


Tim Wright wrote:
> Yes, I've seen this multiple times.
> I also agree that it seems a sensible patch. I have one dumb question.
> Given that we're panicing and we know things are "bad", is there any
> reason not to call smp_send_stop() as early as possible, rather than as
> the last thing which we currently do? As you say, the other cpus are
> happily continuing, potentially destroying data, and it seems that
> stopping this as quickly as possible would be desirable.

That suggestion was my number 2 is my first mail :-)

On the other hand, if we remove the sync stuff, smp_send_stop is called
quite early. Only a printf is called before smp_send_stop().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/