Re: [Lse-tech] [RFC][PATCH] Change pcibus_to_cpumask() to pcibus_to_node()

From: Martin J. Bligh
Date: Wed Jul 28 2004 - 10:06:45 EST


>> I wonder though if we shouldn't add
>>
>> ...
>> # ifdef CONFIG_NUMA
>> int node; /* or nodemask_t if necessary */
>> # endif
>> ...
>>
>> to struct pci_bus instead? That would make the existing code paths a little
>> faster and avoid the need for a global array, which tends to lead to TLB
>> misses.
>
> I like that idea! Stick a nodemask_t in struct pci_bus, initialize it
> to NODE_MASK_ALL. If a particular arch wants to put something more
> accurate in there, then great, if not, we're just in the same boat we're
> in now.
>
> Anyone else have opinions one way or the other on Jesse's idea?

Sounds great - if it's possible to add it to something more generic than
PCI, that'd be even better, but pci would still be very useful.

M.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/