Re: [PATCH] fix zlib debug in ppc boot header

From: Tom Rini
Date: Wed Jul 28 2004 - 11:09:56 EST


On Wed, Jul 28, 2004 at 07:42:13PM +0200, Sam Ravnborg wrote:

> On Wed, Jul 28, 2004 at 08:29:40AM -0700, Tom Rini wrote:
> > On Wed, Jul 28, 2004 at 01:22:22PM +0200, Olaf Hering wrote:
> >
> > > The ppc bootloader code will not compile with zlib debug enabled.
> > > printf was not defined. Tested with vmlinux.coff
> > > This patch was sent out earlier. Appearently it is not possible
> > > to use the generic zlib copy in linux/lib
> > >
> > > Signed-off-by: Olaf Hering <olh@xxxxxxx>
> >
> > Again, I do not want to see this. First, have you run into an occasion
> > where this was needed and helpful? Second, I would much rather see
> > someone just rip out zlib.c and replace it with lib/zlib_deflate than to
> > try and modify the code again.
>
> It should be possible just to include the zlib_deflate.o file from lib/.
> At least oprofile plays suchs ugly tricks.

Can you think of a cleaner way to do this?

--
Tom Rini
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/