Re: -mm swsusp: do not default to platform/firmware

[Nigel Cunningham]

Hi.

Sorry to do this to you - there are still a couple of errors.

On Thu, 2004-07-29 at 17:39, Pavel Machek wrote:
> Thanks, text is now:
> 
> Q: Kernel thread must voluntarily freeze itself (call 'refrigerator'). But

Q: A kernel thread ... 'refrigerator') but ...

(Sentences shouldn't begin with 'But').

> I found some kernel threads that don't do it, and they don't freeze, and

the last ', and' should probably go.

> so the system can't sleep. Is this a known behavior?

American spelling. I'll resist the temptation!

> A: All such kernel threads need to be fixed, one by one. Select place

Select the place

> where it is safe to be frozen (no kernel semaphores should be held at

it -> the thread (the previous subject was plural).

> that point and it must be safe to sleep there), and add:
> 
>             if (current->flags & PF_FREEZE)
>                     refrigerator(PF_FREEZE);
> 
> If the thread is needed for writing the image to storage, you should
> instead set the PF_NOFREEZE process flag when creating the thread.
> 
> I'll eventually push it, too.

Thanks!

Nigel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/