Re: [PATCH] add PCI ROMs to sysfs

From: Jon Smirl
Date: Mon Aug 02 2004 - 12:30:04 EST


--- Jesse Barnes <jbarnes@xxxxxxxxxxxx> wrote:
> look, Greg? It it suitable for the mainline yet? I expect those
> familiar with the various cards to add the necessary quirks code
> as needed.

Radeons need this quirk for broken VBIOS's that leave the ROM decoding
disabled.

unsigned int temp;
temp = DRM_READ32(mmio, RADEON_MPP_TB_CONFIG);
temp &= 0x00ffffffu;
temp |= 0x04 << 24;
DRM_WRITE32(mmio, RADEON_MPP_TB_CONFIG, temp);
temp = DRM_READ32(mmio, RADEON_MPP_TB_CONFIG);

Shouldn't this go into the radeon driver so that it will work with
hotplug? Or should it go in both places, a _devinit pci_quirk and the
radeon driver?


=====
Jon Smirl
jonsmirl@xxxxxxxxx



__________________________________
Do you Yahoo!?
New and Improved Yahoo! Mail - Send 10MB messages!
http://promotions.yahoo.com/new_mail
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/