Re: MTRR driver model support broken on SMP.

From: Nigel Cunningham
Date: Wed Aug 04 2004 - 00:32:11 EST


Hi.

On Wed, 2004-08-04 at 15:31, Zwane Mwaikambo wrote:
> On Wed, 4 Aug 2004, Nigel Cunningham wrote:
>
> > > Looking at this i'm really curious as to whether we need to bother at all,
> > > can you remove the mtrr restore code and then compare /proc/mtrr before
> > > and after suspending.
> >
> > I haven't had problems but do remember 2.4 users who had trouble with X
> > before code to save and restore mtrrs was added.
>
> Ahh yes, X11 will create an additional entry on startup whilst the
> boot MTRR settings don't have it.

Okay. So the question then is how to get them restored. I don't
understand much about the driver model, but it seems to me that all we
should need it get to mtrr save/restore done from the
drivers_suspend/resume calls, which do have interrupts enabled. But how
to achieve that...

Nigel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/