Re: [PATCH] Fix netpoll cleanup on abort without dev

[Jeff Moyer]

==> Regarding [PATCH] Fix netpoll cleanup on abort without dev; Matt Mackall <mpm@xxxxxxxxxxx> adds:

mpm> If netpoll attempts to use a device without polling support, it will
mpm> oops when shutting down. This adds a check that we've actually
mpm> attached to a device.

Hi, Matt,

Perhaps I'm missing something, but how do we successfully return from
netpoll_setup without np->dev filled in?  Netpoll_setup has the following:

        if (!ndev->poll_controller) {
                printk(KERN_ERR "%s: %s doesn't support polling, aborting.\n",
                       np->name, np->dev_name);
                goto release;
        }


Thanks,

Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/