Re: block layer sg, bsg

From: Jens Axboe
Date: Wed Aug 04 2004 - 12:33:42 EST


On Wed, Aug 04 2004, Andi Kleen wrote:
> "David S. Miller" <davem@xxxxxxxxxx> writes:
> >
> > Or use a more portable well-defined type which does not change
> > size nor layout between 32-bit and 64-bit environments.
>
> That is usually a mistake. People get the more subtle issues
> like long long handling wrong, and then it is impossible to fix it
> anymore in a compat layer (examples are ipsec and iptables, which
> cannot be emulated on x86-64 because of that)
>
> So please never pass any structures with read/write/netlink.

Which basically brings us back to SG_IO, or (alternatively) SG_IO_WRITE
and SG_IO_READ ioctls. I doubt that is really worth it, however. There's
just not a huge need to do it.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/