Re: Possible dcache BUG

From: Ingo Molnar
Date: Fri Aug 06 2004 - 03:32:53 EST



* Andrew Morton <akpm@xxxxxxxx> wrote:

> Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > [btw., it would be nice to dump
> > instructions prior the crash point so that we could know precisely what
> > prefetch instruction the kernel included.]
>
> I've had a patch (from Keith) to do that in -mm for over a year, and
> ksymoops has supported it for that long. But I think Linus has some
> problem-which-I-never-understood with the whole idea.

There were some more naive patches around previously i believe and those
problems are solved in this patch: the dump splits the pre-crash and
post-crash instruction stream decoding, so crash-EIP decoding is never
unreliable.

> 25-akpm/arch/i386/kernel/traps.c | 18 ++++++++++--------
> 1 files changed, 10 insertions(+), 8 deletions(-)

a strong ack from me.

Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/