Re: [PATCH][RESENT] remove hardcoded offsets from ppc asm

[Benjamin Herrenschmidt]

On Sun, 2004-08-08 at 01:18, Vincent Hanquez wrote:
> 	Hi LKML,
> 
> This patch removes hardcoded offsets from ppc asm.
> It generate offsets for thread_info structure instead of hardcoding them.
> 
> Please apply or comments,
> 
> Signed-off-by: Vincent Hanquez <tab@xxxxxxxxx>

I have nothing against the idea, but why the hell did you change the
constant names, turning them partially to lowercase ? They are just
fine beeing uppercase, this is more consistent, and that would
reduce the size of your patch signficantly.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/