Re: [2.6 patch] net/seeq8005.c: small cleanups (fwd)

[Adrian Bunk]

On Wed, Aug 11, 2004 at 02:25:46PM -0400, Jeff Garzik wrote:
>...
> >-static const char version[] =
> >-	"seeq8005.c:v1.00 8/07/95 Hamish Coleman 
> >(hamish@xxxxxxxxxxxxxxxx)\n";
>...
> >-	if (net_debug  &&  version_printed++ == 0)
> >-		printk(version);
>...
> This "small cleanup" appears to kill useful and working code.

I'd agree if this was a version number that was regularly updated.

But when is a 9 year old version tag useful?

> 	Jeff

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/