Re: [2.6.8-rc4-bk] NFS oops on x86-64

[Jeff Garzik]

Trond Myklebust wrote:
> På fr , 13/08/2004 klokka 21:07, skreiv Jeff Garzik:
>
> > See attached...   oops in BK-latest NFS client on x86-64.  The oops is 
> > 100% reproducible, and occurs immediately (as soon as I access any 
> > portion of the mounted NFS filesystem; the mount itself succeeds).
>
>
> Does reverting Willy's borken patch fix it? That patch was clearly never
> actually tested before Linus applied it.
>
> I can see 2 problems in the NFS code alone:
>
>   1) Replacing a test for whether or not O_APPEND and O_DIRECT are
> *both* set with one that checks whether either is set.
>   2) Adding a wonderful check in nfs_open() that causes it to return
> immediately if this new nfs_check_flags() returns 0 (i.e. OK).
>
> GRRRR


Yep, reverting the following patch fixes the NFS oops on x86-64...

ChangeSet@xxxxxx, 2004-08-13 09:48:04-07:00, willy@xxxxxxxxxx
  [PATCH] Remove fcntl f_op

  The newly introduced ->fcntl file_operation is badly thought out,
  not to mention undocumented.  This patch replaces it with two better
  defined operations -- check_flags and dir_notify.  Any other fcntl()s
  that filesystems are interested in can have their own properly typed
  f_op method when they need it.

  Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/