Re: Linux v2.6.8

From: Jeff Garzik
Date: Sat Aug 14 2004 - 05:32:15 EST


Linus Torvalds wrote:
Matthew Wilcox:
o Remove fcntl f_op

Any chance of a 2.6.9 with working NFS?

See attached patch, which came from this thread:
http://marc.theaimsgroup.com/?l=linux-kernel&m=109244804202259&w=2
http://marc.theaimsgroup.com/?t=109244611400001&r=1&w=2

===== fs/nfs/file.c 1.40 vs edited =====
--- 1.40/fs/nfs/file.c 2004-08-09 14:58:00 -04:00
+++ edited/fs/nfs/file.c 2004-08-13 23:02:34 -04:00
@@ -72,7 +72,7 @@

static int nfs_check_flags(int flags)
{
- if (flags & (O_APPEND | O_DIRECT))
+ if ((flags & (O_APPEND | O_DIRECT)) == (O_APPEND | O_DIRECT))
return -EINVAL;

return 0;
@@ -89,7 +89,7 @@
int res;

res = nfs_check_flags(filp->f_flags);
- if (!res)
+ if (res)
return res;

lock_kernel();