Re: [PATCH] depends on PCI DMA API: Adaptec AIC7xxx_old

[Geert Uytterhoeven]

On Tue, 20 Jul 2004, Geert Uytterhoeven wrote:
> On Tue, 20 Jul 2004, James Bottomley wrote:
> > On Tue, 2004-07-20 at 13:39, Geert Uytterhoeven wrote:
> > > Adaptec AIC7xxx_old unconditionally depends on the PCI DMA API, so mark it
> > > broken if !PCI
> >
> > Are you sure this is valid?  I thought it used a NULL pci device for
> > EISA (which I hate, but which still apparently works at least on x86).
>
> Wel, I guess we can discuss about that :-)
>
> It uses pci_alloc_consistent() and friends, which are not necessarily defined
> if !PCI. A better solution may be to convert the driver to use the generic DMA
> API instead of the PCI DMA API when PCI is not selected.

In Ottawa you told me this driver really works on ia32 only, so a dependency on
X86 would probably be OK.

However, when grepping through the various defconfigs, it's enabled on ia64 and
ppc (common, pmac, and default), and not on ia32:

| anakin$ find -name "*defconfig*" -type f | xargs grep SCSI_AIC7XXX_OLD  | grep -v 'not set'
| ./arch/ia64/defconfig:CONFIG_SCSI_AIC7XXX_OLD=y
| ./arch/ppc/configs/common_defconfig:CONFIG_SCSI_AIC7XXX_OLD=m
| ./arch/ppc/configs/pmac_defconfig:CONFIG_SCSI_AIC7XXX_OLD=m
| ./arch/ppc/defconfig:CONFIG_SCSI_AIC7XXX_OLD=m

So should I make it depend on X86 || PPC || IA64 instead?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/