Re: [Patch} to fix oops in olympic token ring driver on media disconnect

[Jeff Garzik]

Mike_Phillips@xxxxxxxxxxx wrote:
> > Well, regardless, Neil's patch is IMO a good first step.
>
>
> Neil's patch is to make the annoying regression test failure go away. To 
> be honest I have had *one* user email me that this is a problem and once I 
> gave them the "don't remove the cable on token ring, its not ethernet" 
> talk, they were fine. 


Well I
* disagree the kernel should oops,
* I disagree that olympic should call free_irq in the interrupt handler, and
* I disagree that olympic should do 'dev->stop = NULL' at all, much less 
in the interrupt handler

sorry,

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/