Re: PATCH: add drive_to_key functions

[Alan Cox]

On Llu, 2004-08-16 at 18:12, Bartlomiej Zolnierkiewicz wrote:
> >  	hwif->atapi_dma = 0;		/* disable all atapi dma */
> >  	hwif->ultra_mask = 0x80;	/* disable all ultra */
> >  	hwif->mwdma_mask = 0x80;	/* disable all mwdma */
> >  	hwif->swdma_mask = 0x80;	/* disable all swdma */
> >
> > +	hwif->pci_dev = NULL;
> > +	hwif->remove = NULL;
> > +
> 
> not needed - memsetting to zero is done earlier

Ok fixed in my tree.

> > +EXPORT_SYMBOL_GPL(ide_drive_to_key);
> 
> AFAICS ide_drive_[from,to]_key are to be used only from ide-proc.c
> so EXPORT_SYMBOLs are not needed

Good point I forgot they were linked together. Fixed


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/