[patch] make netpoll budget a bit higher

From: Jeff Moyer
Date: Mon Aug 16 2004 - 17:23:05 EST


Hi, Matt,

I've upped the poll budget to 16 and added a comment explaining why. I
definitely ran into this problem when testing netdump.

Signed-off-by: Jeff Moyer <jmoyer@xxxxxxxxxx>

--- linux-2.6.7/net/core/netpoll.c.budget 2004-08-16 12:33:10.176533688 -0400
+++ linux-2.6.7/net/core/netpoll.c 2004-08-16 12:37:15.510237296 -0400
@@ -61,7 +61,13 @@ static int checksum_udp(struct sk_buff *

void netpoll_poll(struct netpoll *np)
{
- int budget = 1;
+ /*
+ * In cases where there is bi-directional communications, reading
+ * only one message at a time can lead to packets being dropped by
+ * the network adapter, forcing superfluous retries and possibly
+ * timeouts. Thus, we set our budget to a more reasonable value.
+ */
+ int budget = 16;

if(!np->dev || !netif_running(np->dev) || !np->dev->poll_controller)
return;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/