RE: [PATCH][linux-usb-devel] Early USB handoff

From: Aleksey Gorelov
Date: Tue Aug 17 2004 - 14:07:25 EST



>You could reorder and simplify slightly the code for handing off a UHCI
>controller. It's safer to disable PIRQD, SMI#, and legacy
>support first
>and then turn off the interrupt enable bits, all before stopping the
>controller. You could even reset the controller rather than
>just stopping
>it (although you might also want to avoid the 60ms delay this
>requires).
>Take a look at reset_hc() in drivers/usb/host/uhci-hcd.c and
>see what you
>think.

Reset would simplify the code, but also make boot time longer :( I'd
rather sacrifice the code in this case. Actually, it was reset that had
been done in original patch for UHCI and I think was taken from
reset_hc(). Moreover, if one can detect that UHCI has been initialized
in the BIOS already, and just halt it - 60ms reset delay can be avoided
at boot time in the driver as well.
Not sure about reoder though.

Aleks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/