Re: [PATCH] ppc64 mf_proc file position fix

From: Christoph Hellwig
Date: Mon Aug 23 2004 - 12:55:53 EST


On Fri, Aug 20, 2004 at 03:10:32PM -0500, Dave C Boutcher wrote:
> Andrew,
>
> arch/ppc64/kernel/mf_proc.c uses a bad interface for moving
> along file position in a proc_write routine. This quit working
> altogether in 2.6.8. Patch to fix. And I did a quick scan of the
> kernel to see if anyone else was similarly broken...apparantly not :-)
>
> Fixes a broken update of f_pos in a proc file write routine.

What about moving on to seq_file while you're at it? Switching from
one deprecated interface to another doesn't really sound like a worthwile
effort.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/