Re: [patch] voluntary-preempt-2.6.8.1-P8

From: Ingo Molnar
Date: Mon Aug 23 2004 - 18:00:06 EST



* Lee Revell <rlrevell@xxxxxxxxxxx> wrote:

> On Mon, 2004-08-23 at 17:01, Ingo Molnar wrote:
> > i've uploaded the -P8 patch:
> >
> > http://redhat.com/~mingo/voluntary-preempt/voluntary-preempt-2.6.8.1-P8
> >
> > Changes since -P8:
> >
> > - fixes the DRI/DRM latency in radeon (and other drivers). The concept
> > was investigated/tested by Dave Airlie.
> >
> > - reduce netdev_max_backlog to 8 (Mark H Johnson)
> >
>
> Should this fix the 500+ usec latency I saw in rt_garbage_collect?
> This one took a while to occur (overnight).

i dont think it will. Does the patch below help?

Ingo

--- net/ipv4/route.c.orig
+++ net/ipv4/route.c
@@ -738,7 +738,7 @@ static int rt_garbage_collect(void)

if (atomic_read(&ipv4_dst_ops.entries) < ip_rt_max_size)
goto out;
- } while (!in_softirq() && time_before_eq(jiffies, now));
+ } while (!in_softirq() && time_before_eq(jiffies, now) && !need_resched());

if (atomic_read(&ipv4_dst_ops.entries) < ip_rt_max_size)
goto out;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/