Re: [PATCH][2/7] xattr consolidation - LSM hook changes

[Andreas Dilger]

On Aug 23, 2004  20:03 +0100, Christoph Hellwig wrote:
> On Mon, Aug 23, 2004 at 02:16:17PM -0400, James Morris wrote:
> > This patch replaces the dentry parameter with an inode in the LSM
> > inode_{set|get|list}security hooks, in keeping with the ext2/ext3 code.
> > dentries are not needed here.
> 
> Given that the actual methods take a dentry this sounds like a bad design.
> Can;t you just pass down the dentry through all of the ext2 interfaces?
> 
> (And again, mid-term these checks should move to the VFS)

Actually, I recall something about it being desirable to pass the dentry
down instead of just the inode, maybe Andreas G. recalls?

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://members.shaw.ca/adilger/             http://members.shaw.ca/golinux/

Attachment: pgp00000.pgp
Description: PGP signature