Re: [PATCH][2/7] xattr consolidation - LSM hook changes

[viro]

On Mon, Aug 23, 2004 at 08:54:14PM -0400, James Morris wrote:
> On Mon, 23 Aug 2004, Stephen Smalley wrote:
> 
> > On Mon, 2004-08-23 at 15:03, Christoph Hellwig wrote:
> 
> > > Given that the actual methods take a dentry this sounds like a bad design.
> > > Can;t you just pass down the dentry through all of the ext2 interfaces?
> > 
> > Changing the methods to take an inode would be even better, IMHO, as the
> > dentry is unnecessary.  That would simplify SELinux as well.
> 
> This could work for all in-tree filesystems with xattrs, except CIFS,
> which passes the dentry to it's own build_path_from_dentry() function.  
> 
> (In this case, they probably want to use d_path() and have a vfsmnt added 
> to the methods?).

No.  Think for a second and you'll see why - we are doing an operation that
by definition should not depend on where we have mounted the filesystem in
question.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/