RE: [PATCH] [broken?] Add MSI support to e1000

[Nguyen, Tom L]

On Tuesday, August 24 Roland Dreier wrote: 
>    Andi> Yes, the flag word is 0x8b after the call. And
>    Andi> pci_enable_msi returns 0.
>
>Actually I bet the problem is that the driver is doing request_irq()
>on the wrong IRQ.  In s2io.c, s2io_init_nic() does
>
>	sp->irq = pdev->irq;
>
>and then sometime later s2io_open() does
>
>	err =
>	    request_irq((int) sp->irq, s2io_isr, SA_SHIRQ, sp->name,
dev);
>
>If you put the call to pci_enable_msi() after sp->irq is assigned, the
>driver will request the original irq (which will still be in INTx
>mode, of course), rather than the new vector assigned by the MSI core.

My guess is the same as Roland's bet. I've not tested MSI support in 
2.6.8.1 kernel. I'll provide an update later if MSI support
in x86-64 has any issue.

Thanks,
Long
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/