Re: [PATCH] kallsyms data size reduction / lookup speedup

From: Andrew Morton
Date: Thu Aug 26 2004 - 05:13:57 EST


viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx wrote:
>
> On Thu, Aug 26, 2004 at 12:40:30AM +0100, Paulo Marques wrote:
> > That is why I kept a big *If* in that sentence. I'm quite new to all
> > this, and I'm still reading a lot of source code.
> >
> > If the culprit is in fact seq_file, and seq_file can be improved in a
> > way that works for everyone (not only kallsyms), then I also agree
> > that is is the way to go. But hunting this down might prove that the
> > problem is somewhere else. It is just too soon to draw conclusions.
>
> readprofile(1) ought to narrow it down with that kind of timing difference...



c014696c do_anonymous_page 4 0.0133
c0133550 kallsyms_expand_symbol 17 0.1545
c026b78f __copy_user_intel 31 0.2039
c026a5ec vsnprintf 39 0.0283
c026a318 number 40 0.0552
c011d102 write_profile 79 0.7182
c0131f39 is_exported 3805 17.0628
c0104028 default_idle 4254 86.8163
00000000 total 8325 0.0025

It's all in the O(n) is_exported(). Rusty's fault ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/