Re: [RFC] buddy allocator without bitmap [3/4]

[Dave Hansen]

> +                       if (zone->nr_mem_map > 1) {
> +                               /*
> +                                * there may be hole in zone's memmap &&
> +                                * hole is not aligned in this order.
> +                                * currently, I think CONFIG_VIRTUAL_MEM_MAP
> +                                * case is only case to reach here.
> +                                * Is there any other case ?
> +                                */
> +                               /*
> +                                * Is there better call than pfn_valid ?
> +                                */
> +                               if (!pfn_valid(zone->zone_start_pfn
> +                                              + (page_idx ^ (1 << order))))
> +                                       break;
> +                       }

Nice try.  How about putting the ia64 code in a macro or header function
that you can #ifdef out on all the other architectures?  We used to be
able to see that entire while loop on one screen.  That's a bit harder
now.  

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/