Re: [2.4 patch][5/6] asm-i386/smpboot.h: fix gcc 3.4 compilation

[Willy Tarreau]

On Thu, Aug 26, 2004 at 11:38:39PM +0300, O.Sezer wrote:
> Didn't look at the code much but how about removing the
> label as the -ac tree does?
> 

I remember I once had to add an empty default case in a switch/case in one of
my programs to stop gcc from complaining. I think it is the same here and the
'default' does not harm anyway.

And please remember, as a rule of thumb, if it does not change semantics nor
the code produced, please try to avoid moving parts of the stable kernel.
There are many people who have to apply other patches on top of a vanilla
kernel and who don't like it very much when they get rejects just because
of a recent code "beautification".

Regards,
Willy

> diff -urN 28pre2/include/asm-i386/smpboot.h 28pre2_acx/include/asm-i386/smpboot.h
> --- 28pre2/include/asm-i386/smpboot.h	2004-08-08 02:26:06.000000000 +0300
> +++ 28pre2_acx/include/asm-i386/smpboot.h	2004-08-26 12:09:44.000000000 +0300
> @@ -129,7 +129,6 @@
>  			/*round robin the interrupts*/
>  			cpu = (cpu+1)%smp_num_cpus;
>  			return cpu_to_physical_apicid(cpu);
> -		default:
>  	}
>  	return cpu_online_map;
>  }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/