Re: 2.6.8.1-mm1 and Asus L3C : problematic change found, can be reverted.Real fix still missing

From: Eric Valette
Date: Sun Aug 29 2004 - 08:53:55 EST


Dominik Brodowski wrote:
On Thu, Aug 19, 2004 at 10:05:45AM +0200, Eric Valette wrote:

Li, Shaohua wrote:

Eric,
The patch for bug 3049 has been in 2.6.8.1 and should fix the IO port
problem. If the Asus quirk is just because of IO port problem, I'd like
to remove it.

It's not because of the IO port problem -- actually, this "IO" problem is a
new appearance, while the Asus quirk works perfectly for many people.


Note PNP driver also reserves the IO port for the SMBus
and lets SMBus driver to use it. ACPI motherboard driver behaves the
same as PNP driver.

Unfortunately, as I understand it, the fix is done to "unhide" the SMBus that otherwyse is not seen but it has unexpected side effect of messing ioports allocation/reservation. I guess lspci with and without the fix could help to understand the problem.


Indeed. lspci without the fix doesn't show the device, lspci with the fix
shows the device.

Dominik

Dominik,

This is a little bit late. There are already two fixes for the SMBus unhidding : one generic by linux, that is in 2.6.9-rc1-bk2 or 2.6.9-rc1-mm1 that fixes the SMBus but that is not really SMBus related and one specific that you can find at <http://bugme.osdl.org/show_bug.cgi?id=3191>. Linux blessed this patch as it makes clear that unhiding the bus without reserving the IO space is the root of the real problem but did not incorporate it probably because the other fix is already in and mine should be done for buggy BIOS (DTST) that access the hidden SMBus not indirect the IO BAR but via hardwired values,

Patch is not yet merged and may well never be as now problem is masked,


--
__
/ ` Eric Valette
/-- __ o _. 6 rue Paul Le Flem
(___, / (_(_(__ 35740 Pace

Tel: +33 (0)2 99 85 26 76 Fax: +33 (0)2 99 85 26 76
E-mail: eric.valette@xxxxxxx



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/