[PATCH] Fix another PNP leak.

From: Dave Jones
Date: Wed Sep 01 2004 - 12:24:17 EST


Spotted with the source checker from Coverity.com.

Signed-off-by: Dave Jones <davej@xxxxxxxxxx>


diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/pnp/pnpbios/core.c linux-2.6/drivers/pnp/pnpbios/core.c
--- bk-linus/drivers/pnp/pnpbios/core.c 2004-07-14 00:00:48.000000000 +0100
+++ linux-2.6/drivers/pnp/pnpbios/core.c 2004-08-23 14:08:16.000000000 +0100
@@ -252,8 +252,10 @@ static int pnpbios_set_resources(struct
node = pnpbios_kmalloc(node_info.max_node_size, GFP_KERNEL);
if (!node)
return -1;
- if (pnp_bios_get_dev_node(&nodenum, (char )PNPMODE_DYNAMIC, node))
+ if (pnp_bios_get_dev_node(&nodenum, (char )PNPMODE_DYNAMIC, node)) {
+ kfree(node);
return -ENODEV;
+ }
if(pnpbios_write_resources_to_node(res, node)<0) {
kfree(node);
return -1;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/