[2/7] make do_each_task_pid()/while_each_task_pid() require a semicolon following them

From: William Lee Irwin III
Date: Wed Sep 01 2004 - 12:37:15 EST


On Wed, Sep 01, 2004 at 10:27:10AM -0700, William Lee Irwin III wrote:
> list_empty(&task->pids[type].hash_list) does not successfully typecheck;
> while this does not correct its semantics, it at least restores
> typechecking long enough for the code to be examined.

do { ... } while () -like constructs require semicolons to follow them.
This patch arranges for do_each_task_pid() { ... } while_each_task_pid()
to do likewise.


Index: kirill-2.6.9-rc1-mm2/include/linux/pid.h
===================================================================
--- kirill-2.6.9-rc1-mm2.orig/include/linux/pid.h 2004-09-01 08:49:14.584737520 -0700
+++ kirill-2.6.9-rc1-mm2/include/linux/pid.h 2004-09-01 09:01:13.653422464 -0700
@@ -41,6 +41,7 @@
extern void switch_exec_pids(struct task_struct *leader, struct task_struct *thread);

#define do_each_task_pid(who, type, task) \
+do { \
if ((task = find_task_by_pid_type(type, who))) { \
prefetch(task->pids[type].pid_list.next); \
do {
@@ -49,7 +50,8 @@
task = pid_task(task->pids[type].pid_list.next, \
type); \
prefetch(task->pids[type].pid_list.next); \
- } while (task->pids[type].hash_list.next); \
- }
+ } while (task->pids[type].hash_list.next); \
+ } \
+} while (0)

#endif /* _LINUX_PID_H */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/