Re: [2.6 patch] kill __always_inline

[Andrew Morton]

Tim Bird <tim.bird@xxxxxxxxxxx> wrote:
>
> Finally, I think it's bad form to change the meaning of a compiler
> keyword.  It misleading for 'inline' to mean something different
> in the kernel than it does everywhere else.  It means a developer
> can't use standard gcc documentation to understand kernel code, without
> inside knowledge.  This can be painful for casual or new kernel
> developers.

yes, it's horrid.  But until and unless gcc gets fixed, what choice do we
have?  Without this hack, kernel text size increases significantly.

We don't want to have to patch the kernel source in a zillion places for
what is hopefully a temporary problem.  I'd much rather add `--dwim-dammit'
to the gcc command line.

> +#include <linux/compiler.h>	/* for inline weirdness */
>   #include <asm/param.h>

Mozilla white-space-stuffed your patch.  You'll have to use attachments.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/